Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wand combat origin type #3683

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Add Wand combat origin type #3683

merged 5 commits into from
Oct 5, 2021

Conversation

EPuncker
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Follow-up of 9876f2f#diff-ee28d186e505762f7d874ee619cae401419c6fdb6ea8c5817d44b148f397f8c9R412-R417

Issues addressed:
none

@MillhioreBT
Copy link
Contributor

The magic wands are not necessarily ranged weapons, so in my opinion it would be better to create a new type of origin.
Example: ORIGIN_WAND
This will bring with it an improvement when creating a script to improve attacks that come from magic wands and much easly

@soul4soul
Copy link
Contributor

The magic wands are not necessarily ranged weapons, so in my opinion it would be better to create a new type of origin.
Example: ORIGIN_WAND
This will bring with it an improvement when creating a script to improve attacks that come from magic wands and much easly

Agreed, I almost suggested ORIGIN_SPELL should be used but you are right a new type of origin should be added for wands.

@EPuncker EPuncker changed the title Add Wand weapon type damage to count as ranged Add Wand combat origin type Sep 25, 2021
@EPuncker
Copy link
Contributor Author

@MillhioreBT @soul4soul okay guys you won

Copy link
Contributor

@MillhioreBT MillhioreBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EPuncker EPuncker merged commit 8a3aee3 into master Oct 5, 2021
@EPuncker EPuncker deleted the EPuncker-patch-1 branch October 5, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants