Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix level and condition check for yell #3690

Merged
merged 6 commits into from
Oct 3, 2021
Merged

Fix level and condition check for yell #3690

merged 6 commits into from
Oct 3, 2021

Conversation

ramon-bernardo
Copy link
Contributor

@ramon-bernardo ramon-bernardo commented Sep 25, 2021 •
edited
Loading

Pull Request Prelude

Changes Proposed

  • Fix level and condition check for yell
  • Player with group access or ignoresendprivatecheck flag ignore checks and condition

EPuncker
EPuncker previously approved these changes Sep 25, 2021
View reviewed changes
@EPuncker EPuncker added priority: low Issues with this label won’t have the immediate focus bugfix labels Sep 25, 2021
@ramon-bernardo
Copy link
Contributor Author

ramon-bernardo commented Sep 25, 2021 •
edited
Loading

Added new flag.

  • const.h may conflict with PlayerFlag_IgnoreSendPrivateCheck = static_cast<uint64_t>(1) << 38

@EPuncker EPuncker merged commit 4a49e31 into otland:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EPuncker EPuncker EPuncker approved these changes

@DSpeichert DSpeichert Awaiting requested review from DSpeichert

@nekiro nekiro Awaiting requested review from nekiro

@ranisalt ranisalt Awaiting requested review from ranisalt

Assignees
No one assigned
Labels
bugfix priority: low Issues with this label won’t have the immediate focus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramon-bernardo @EPuncker