Move player task-delay

[ramon-bernardo]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

• Move player task-delay

[EPuncker]

I think it would be nicer if we had them at game.h as we have these:

https://github.com/otland/forgottenserver/blob/master/src/game.h#L66-L69

[ramon-bernardo]

I think it would be nicer if we had them at game.h as we have these:

https://github.com/otland/forgottenserver/blob/master/src/game.h#L66-L69

Its a good point. Changed.

[ghost]

that would still mean they are hardcoded, so no point in pr xD

[ranisalt]

that would still mean they are hardcoded, so no point in pr xD

At least we avoid the magic numbers sprinkled around

[ranisalt]

Big finger on phone screen attacks again

[slawkens]

Looks good, making code more readable.

However, I would use the same convention as other variables do, that is: first the prefix, then the rest of variable name. Like INTERVAL_*

Like this:

MOVE_CREATURE_INTERVAL ->INTERVAL_MOVE_CREATURE
RANGE_MOVE_CREATURE_INTERVAL -> INTERVAL_RANGE_MOVE_CREATURE

Other than that, LGTM!

[ramon-bernardo]

Looks good, making code more readable.

However, I would use the same convention as other variables do, that is: first the prefix, then the rest of variable name. Like INTERVAL_*

Like this:

MOVE_CREATURE_INTERVAL ->INTERVAL_MOVE_CREATURE RANGE_MOVE_CREATURE_INTERVAL -> INTERVAL_RANGE_MOVE_CREATURE

Other than that, LGTM!

I didn't find use of interval on front, but I like interval_...

[slawkens]

Ignore that, I was going too much into details 😉

[Zbizu]

did it close #1845?

[ramon-bernardo]

did it close #1845?

No, delay here is from the server and has nothing to do with packets.
Unfortunately we still don't have a solution for this.