Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix summon memory leak #3736

Merged
merged 2 commits into from
Feb 19, 2022
Merged

Fix summon memory leak #3736

merged 2 commits into from
Feb 19, 2022

Conversation

ramon-bernardo
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • When summon disappears there's race condition in which surrounding monsters may not remove that summon from their targetlist which results in summon memory leakage and those monsters never will be in idle state again.

@SaiyansKing

@ramon-bernardo
Fix summon memory leak
54d3cf7 
- when summon disappears there's race condition in which surrounding monsters may not remove that summon from their targetlist which results in summon memory leakage and those monsters never will be in idle state again.
@ramon-bernardo
Copy link
Contributor Author

How to reproduce this:

/m demon
/summon demon
/r on summon

demon never stop dance

@soul4soul
Copy link
Contributor

I have seen this before testing changes on my GM char using a summon and a monster.

DSpeichert
DSpeichert previously approved these changes Feb 6, 2022
View reviewed changes
nekiro
nekiro reviewed Feb 6, 2022
View reviewed changes
src/game.cpp Outdated Show resolved Hide resolved
@EPuncker EPuncker merged commit f4205e3 into otland:master Feb 19, 2022
Znote pushed a commit to Znote/forgottenserver that referenced this pull request Feb 23, 2022
@ramon-bernardo @Znote
Fix summon memory leak (otland#3736)
a99780f
@ramon-bernardo ramon-bernardo deleted the sumn-mem-leak branch April 2, 2022 11:27
DSpeichert pushed a commit that referenced this pull request May 9, 2022
@ramon-bernardo @DSpeichert
Fix summon memory leak (#3736)
4835b75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekiro nekiro nekiro left review comments

@EPuncker EPuncker EPuncker approved these changes

@DSpeichert DSpeichert DSpeichert left review comments

@ranisalt ranisalt Awaiting requested review from ranisalt

Assignees
No one assigned
Labels
bugfix priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ramon-bernardo @soul4soul @DSpeichert @EPuncker @nekiro