Fix invalid NPC items on trade #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an item is not valid (it doesn't exist in items.xml), do not allow NPC to show it on trade window. Signed-off-by: Lucas Henrique Grizante <lucasgrizante95@gmail.com>
EPuncker
approved these changes
Nov 13, 2021
Znote
pushed a commit
to Znote/forgottenserver
that referenced
this pull request
Jan 30, 2022
DSpeichert
pushed a commit
that referenced
this pull request
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
If an item is not valid (it doesn't exist in items.xml), do not allow
NPC to show it on trade window.
Issues addressed:
Steps to reproduce issue:
Create an npc that sells or buys an item that doesn't exist (for instance, copying from other distros with more items, such as tibia 12 items in 10.98 TFS distro) and ask him/her to trade. You'll see some empty items.