[11.80] Added new monster 'ink' race and fluid type #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPuncker
requested review from
ranisalt,
DSpeichert and
nekiro
and removed request for
ranisalt and
DSpeichert
ranisalt
reviewed
Nov 19, 2021
src/const.h
Outdated
| @@ -113,6 +113,7 @@ enum MagicEffectClasses : uint8_t { | |||
| CONST_ME_CRITICAL_DAMAGE = 173, | |||
| // 174 is empty | |||
| CONST_ME_PLUNGING_FISH = 175, | |||
| CONST_ME_DRAWINK = 202, | |||
There was a problem hiding this comment.
Suggested change
| CONST_ME_DRAWINK = 202, | |
| CONST_ME_DRAW_INK = 202, |
?
There was a problem hiding this comment.
I just wanted to follow DRAWBLOOD pattern 😄
| @@ -3913,6 +3913,15 @@ void Game::combatGetTypeInfo(CombatType_t combatType, Creature* target, TextColo | |||
| color = TEXTCOLOR_ELECTRICPURPLE; | |||
| effect = CONST_ME_ENERGYHIT; | |||
| break; | |||
| case RACE_INK: | |||
| color = TEXTCOLOR_BLACK; | |||
| effect = CONST_ME_DRAWINK; | |||
There was a problem hiding this comment.
Suggested change
| effect = CONST_ME_DRAWINK; | |
| effect = CONST_ME_DRAW_INK; |
|
works fine |
omarcopires
previously approved these changes
Dec 2, 2021
DSpeichert
previously approved these changes
Dec 14, 2021
DSpeichert
dismissed stale reviews from omarcopires and themself
via
0b2cba5
DSpeichert
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Issues addressed: