feat: special magic level #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe that they should also be pushed to lua (in itemType:getAbilities()) also, the variable names could be shortened to just MAGICLEVELELEMENT rather than SPECIALMAGICLEVELELEMENT |
EPuncker
reviewed
Dec 12, 2021
EPuncker
requested changes
Dec 13, 2021
omarcopires
reviewed
Dec 14, 2021
ArturKnopik
added a commit
to ArturKnopik/forgottenserver
that referenced
this pull request
Dec 18, 2021
> Specialised Magic Levels: items will be able to receive a magic level modifier for specific elements, e.g. "fire magic level +2", which means only fire damage spells are boosted. Possible elements include Fire, Earth, Energy, Ice, Holy, Death and Healing. https://tibia.fandom.com/wiki/Updates/12.70.10953
ArturKnopik
added a commit
to ArturKnopik/forgottenserver
that referenced
this pull request
Dec 18, 2021
This reverts commit 2fa29a1.
|
This feature ends a task from issue #3758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
16:06 You see a rainbow shield (Def:30, energy magic level +20, fire magic level +3, healing magic level +10).
It can only be wielded properly by knights of level 100 or higher.
It weighs 69.00 oz.
Strange elemental magic flows over this shield.
{"magiclevelenergy", ITEM_PARSE_MAGICLEVELENERGY},
{"magiclevelfire", ITEM_PARSE_MAGICLEVELFIRE},
{"magiclevelpoison", ITEM_PARSE_MAGICLEVELPOISON},
{"magiclevelearth", ITEM_PARSE_MAGICLEVELPOISON},
{"magiclevelice", ITEM_PARSE_MAGICLEVELICE},
{"magiclevelholy", ITEM_PARSE_MAGICLEVELHOLY},
{"magicleveldeath", ITEM_PARSE_MAGICLEVELDEATH},
{"magiclevellifedrain", ITEM_PARSE_MAGICLEVELLIFEDRAIN},
{"magiclevelmanadrain", ITEM_PARSE_MAGICLEVELMANADRAIN},
{"magicleveldrown", ITEM_PARSE_MAGICLEVELDROWN},
{"magiclevelphysical", ITEM_PARSE_MAGICLEVELPHYSICAL},
{"magiclevelhealing", ITEM_PARSE_MAGICLEVELHEALING},
{"magiclevelundefined", ITEM_PARSE_MAGICLEVELUNDEFINED},
Pull Request Prelude