Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the client crash when you open the missions window #3844

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Fix the client crash when you open the missions window #3844

merged 1 commit into from
Dec 13, 2021

Conversation

MillhioreBT
Copy link
Contributor

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

The client 12.81 now needs the index of the mission that is sent to him, I do not know if it is the best way or if we need to identify the missions in another way that is not the index of the list

Issues addressed: Nothing!

@Zbizu
Copy link
Contributor

Zbizu commented Dec 13, 2021

You may track quests progress now. This is why it got an extra value. Overall quest log should have been rewritten, but I remember that the maintainers desire to keep compatibility blocked the pr in the past.

It's ok for now to add a placeholder though.

@omarcopires
Copy link
Contributor

Maybe it's better to look this way rather than a partial solution, of course it's just a suggestion, but it would be interesting if you bring us your version of the code.

If possible take a look at this:
igorzerah/optimized_forgottenserver@7b23b35
igorzerah/optimized_forgottenserver@63503e1
igorzerah/optimized_forgottenserver@c8f4d42

Copy link
Contributor

@EPuncker EPuncker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed there is a client crash (you can test it by having a non empty quest log), and this code does fix it.

@EPuncker EPuncker merged commit f4ec19a into otland:master Dec 13, 2021
ArturKnopik pushed a commit to ArturKnopik/forgottenserver that referenced this pull request Dec 18, 2021
ArturKnopik added a commit to ArturKnopik/forgottenserver that referenced this pull request Dec 18, 2021
@ranisalt
Copy link
Member

And this has broken the other way around to OTClient 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants