Adding addon items from the Poltergeist Outfit #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarcopires
changed the title
EPuncker
previously approved these changes
Dec 15, 2021
EPuncker
approved these changes
Dec 15, 2021
Znote
added a commit
to Znote/forgottenserver
that referenced
this pull request
Dec 18, 2021
Followup on otland#3847 * Simplified the code and added comments * Each conditional operation is unique (etc: does not perform the same checks twice in the code) * * Such as `player:isPremium()` and `player:hasOutfit(looktype)` * More granulated feedback (instead of saying 1 of 3 things stopped you from using this item) * Error messages are sent using CancelMessage instead of MESSAGE_EVENT_ADVANCE * * Maybe it would be appropriate to also add CONST_ME_POFF effect? * `useItem` renamed to `outfitConfig` to make it less misleading, since the variable represents a config table, not the used item.
EPuncker
pushed a commit
that referenced
this pull request
Dec 18, 2021
Followup on #3847 * Simplified the code and added comments * Each conditional operation is unique (etc: does not perform the same checks twice in the code) * * Such as `player:isPremium()` and `player:hasOutfit(looktype)` * More granulated feedback (instead of saying 1 of 3 things stopped you from using this item) * Error messages are sent using CancelMessage instead of MESSAGE_EVENT_ADVANCE * * Maybe it would be appropriate to also add CONST_ME_POFF effect? * `useItem` renamed to `outfitConfig` to make it less misleading, since the variable represents a config table, not the used item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Adding possibility to get new outfits
It is necessary to add the #3810