Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed capacity display for GMs #3849

Merged
merged 3 commits into from
Dec 14, 2021
Merged

Fixed capacity display for GMs #3849

merged 3 commits into from
Dec 14, 2021

Conversation

EPuncker
Copy link
Contributor

@EPuncker EPuncker commented Dec 14, 2021

Pull Request Prelude

Changes Proposed

Issues addressed:
2021-12-14 15_36_50-Feature_ Breakable mana shield and condition root by ArturKnopik · Pull Request

now it will display 10000 instead of the ugly above

@EPuncker EPuncker requested review from DSpeichert, ranisalt and nekiro and removed request for DSpeichert December 14, 2021 18:53
@Zbizu
Copy link
Contributor

Zbizu commented Dec 14, 2021

back in my days, it was 10000

@DSpeichert DSpeichert merged commit 9b7b99f into master Dec 14, 2021
@DSpeichert DSpeichert deleted the EPuncker-patch-2 branch December 14, 2021 23:37
@ghost
Copy link

ghost commented Dec 15, 2021

back in my days, it was 10000

actually it should display as 0 :)

@nekiro
Copy link
Member

nekiro commented Dec 15, 2021

back in my days, it was 10000

actually it should display as 0 :)

Yeah, I would vote for this option, it's self descriptive :D

@EPuncker
Copy link
Contributor Author

back in my days, it was 10000

actually it should display as 0 :)

Yeah, I would vote for this option, it's self descriptive :D

QT client is weird, if we display 0 we won't be able to buy anything at npc

@nekiro
Copy link
Member

nekiro commented Dec 15, 2021

back in my days, it was 10000

actually it should display as 0 :)

Yeah, I would vote for this option, it's self descriptive :D

QT client is weird, if we display 0 we won't be able to buy anything at npc

cipsoft verifying both client and server side, nice

@Zbizu
Copy link
Contributor

Zbizu commented Dec 16, 2021

Can't trust the client though. Yurots was trusting the game client and people were moving walls around with hacks.

@omarcopires omarcopires mentioned this pull request Dec 12, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants