Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usages of str*cmp with C++ functions #4018

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Replace usages of str*cmp with C++ functions #4018

merged 2 commits into from
Mar 17, 2022

Conversation

ranisalt
Copy link
Member

Pull Request Prelude

Changes Proposed

Just replacing some C code with C++

nekiro
nekiro previously approved these changes Mar 16, 2022
View reviewed changes
MillhioreBT
MillhioreBT reviewed Mar 17, 2022
View reviewed changes
src/tools.cpp Outdated Show resolved Hide resolved
@ranisalt ranisalt requested a review from nekiro March 17, 2022 09:08
@EPuncker EPuncker merged commit 336ea63 into otland:master Mar 17, 2022
@ranisalt ranisalt deleted the drop-strcmp branch March 17, 2022 20:08
EPuncker pushed a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
@ranisalt @EPuncker
Replace usages of str*cmp with C++ functions (otland#4018)
71a5a69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSpeichert DSpeichert DSpeichert approved these changes

@EPuncker EPuncker EPuncker approved these changes

@MillhioreBT MillhioreBT MillhioreBT approved these changes

@nekiro nekiro Awaiting requested review from nekiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ranisalt @DSpeichert @EPuncker @nekiro @MillhioreBT