Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid sending none magic effect #4177

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Avoid sending none magic effect #4177

merged 2 commits into from
Jul 6, 2022

Conversation

ramon-bernardo
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • Avoid sending CONST_ME_NONE magic effect to players.

EPuncker
EPuncker previously approved these changes Jul 3, 2022
View reviewed changes
Zbizu
Zbizu previously approved these changes Jul 3, 2022
View reviewed changes
@ramon-bernardo ramon-bernardo dismissed stale reviews from Zbizu and EPuncker via 6e0d2d1 July 5, 2022 23:53
@EPuncker EPuncker requested a review from nekiro July 6, 2022 00:44
@EPuncker EPuncker merged commit 128f3b1 into master Jul 6, 2022
@EPuncker EPuncker deleted the avoid-send-none-me branch July 6, 2022 11:07
EPuncker pushed a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
@ramon-bernardo @EPuncker
Avoid sending none magic effect (otland#4177)
0414221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EPuncker EPuncker EPuncker approved these changes

@nekiro nekiro nekiro approved these changes

@Zbizu Zbizu Zbizu left review comments

@DSpeichert DSpeichert Awaiting requested review from DSpeichert

@yamaken93 yamaken93 Awaiting requested review from yamaken93

@Znote Znote Awaiting requested review from Znote

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ramon-bernardo @EPuncker @Zbizu @nekiro