Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: not being able to login with latest client due to incorrect max client version #4179

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

EPuncker
Copy link
Contributor

@EPuncker EPuncker commented Jul 6, 2022

Pull Request Prelude

Changes Proposed

Players were unable to connect with client version 12.87.12128 because despite the "visual" version being 12.87, it was is internally 12.88, so I've changed it and tested this time. Now its possible to login and play with any client from 12.80 to 12.87 version range.

Issues addressed:
not being able to login with latest client (12.87.12128 as of this date)

@EPuncker EPuncker merged commit f288619 into master Jul 6, 2022
@EPuncker EPuncker deleted the EPuncker-patch-2 branch July 6, 2022 23:43
@Infolinia
Copy link

I can change to 10.98 version?
static constexpr auto CLIENT_VERSION_MIN = 1097; static constexpr auto CLIENT_VERSION_MAX = 1098; static constexpr auto CLIENT_VERSION_STR = "10.98";

@EPuncker
Copy link
Contributor Author

I can change to 10.98 version? static constexpr auto CLIENT_VERSION_MIN = 1097; static constexpr auto CLIENT_VERSION_MAX = 1098; static constexpr auto CLIENT_VERSION_STR = "10.98";

no, for 10.98 you must use 1.4.x version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants