Add creature isDead function #4231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramon-bernardo
changed the title
ramon-bernardo
commented
Oct 28, 2022
| @@ -850,7 +850,7 @@ bool InstantSpell::playerCastInstant(Player* player, std::string& param) | |||
| } | |||
|
|
|||
| target = playerTarget; | |||
| if (!target || target->getHealth() <= 0) { | |||
| if (!target || target->isDead()) { | |||
There was a problem hiding this comment.
Suggested change
| if (!target || target->isDead()) { | |
| if (!target || target->isRemoved() || target->isDead()) { |
Missing removed check?
ramon-bernardo
commented
Oct 28, 2022
| @@ -884,7 +884,7 @@ bool InstantSpell::playerCastInstant(Player* player, std::string& param) | |||
| } | |||
| } else { | |||
| target = player->getAttackedCreature(); | |||
| if (!target || target->getHealth() <= 0) { | |||
| if (!target || target->isDead()) { | |||
|
Maybe has hasHealth() could be reaplced with !isDead()? I believe in the contexts that hasHealth() is called we are checking to see if the creature is alive (!isdead). |
isAlive and isDead? |
isDead makes more sense |
EPuncker
approved these changes
Oct 30, 2022
ramon-bernardo
changed the title
EPuncker
pushed a commit
to EPuncker/forgottenserver
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed