remove pagezero_size deprecation warning on macos version >=13.0 #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DSpeichert can you take care of the wiki page as well? |
nekiro
approved these changes
Mar 3, 2023
|
There is one thing that I noticed when compiling tfs on macos that sometimes pugixml (FindPugiXml.cmake) causes some bad lookups, it compiles and links fine, but tfs instantly crashes on startup. I fixed this locally by just deleting that cmake file and it works just fine. |
ranisalt
approved these changes
Mar 6, 2023
EPuncker
approved these changes
Mar 6, 2023
EPuncker
pushed a commit
to EPuncker/forgottenserver
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Remove
-pagezero_size 10000 -image_base 100000000linker flags, as they are deprecated as of macOS 13.0. Indeed, binaries built with these flags are killed upon startup. Plus, the compilation Wiki for macOS should be updated, too.mysql-connector-chas been deprecated in favour ofmysql-client.