Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved "teleport click" to lua #4361

Merged
merged 3 commits into from
Apr 2, 2023
Merged

Moved "teleport click" to lua #4361

merged 3 commits into from
Apr 2, 2023

Conversation

reyaleman
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Moved Ctrl + Shift + LMB (Teleport click) to LUA.

We still need to discuss folder structure for this and future pull requests... 😄

Issues addressed:
(none)

@reyaleman reyaleman changed the title gm_teleport Moved "teleport click" to lua Apr 1, 2023
@EPuncker
Copy link
Contributor

EPuncker commented Apr 1, 2023

script/modules maybe

@ranisalt
Copy link
Member

ranisalt commented Apr 1, 2023

I was going to move playerToggleMount to Lua inside the scripts/network folder, good that you raised the topic

@reyaleman
Copy link
Contributor Author

I was going to move playerToggleMount to Lua inside the scripts/network folder, good that you raised the topic

Yep, scripts/network seems to be more appropiate.

@EPuncker
Copy link
Contributor

EPuncker commented Apr 1, 2023

I was going to move playerToggleMount to Lua inside the scripts/network folder, good that you raised the topic

Yep, scripts/network seems to be more appropiate.

yeah, lets stick to it

EPuncker
EPuncker previously approved these changes Apr 1, 2023
View reviewed changes
@EPuncker EPuncker requested a review from ranisalt April 2, 2023 03:17
@ranisalt ranisalt merged commit 7589c3b into otland:master Apr 2, 2023
@reyaleman reyaleman deleted the gmteleport-lua branch April 2, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EPuncker EPuncker EPuncker approved these changes

@DSpeichert DSpeichert Awaiting requested review from DSpeichert

@nekiro nekiro Awaiting requested review from nekiro

@ranisalt ranisalt Awaiting requested review from ranisalt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reyaleman @EPuncker @ranisalt