Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: in-game highscores #4421

Merged
merged 9 commits into from
May 12, 2023
Merged

feature: in-game highscores #4421

merged 9 commits into from
May 12, 2023

Conversation

reyaleman
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • Added in-game highscores feature...
  • Easy to add custom highscores like "Most deaths, online times, storage checks, etc..."

Needs testing, suggestions & code review

Issues addressed:

@ranisalt
Copy link
Member

It seems that the list of vocations is defined by the server. In this scenario, we do not have to lock to the regular vocations, since we can just use what vocations are set in vocations.xml

EPuncker
EPuncker previously approved these changes Apr 24, 2023
View reviewed changes
omarcopires
omarcopires previously approved these changes Apr 24, 2023
View reviewed changes
@EPuncker EPuncker added the feature New feature or functionality label Apr 24, 2023
ranisalt
ranisalt reviewed Apr 24, 2023
View reviewed changes
data/lib/core/core.lua Outdated Show resolved Hide resolved
@reyaleman reyaleman dismissed stale reviews from omarcopires and EPuncker via d7292f9 April 24, 2023 23:48
@EPuncker EPuncker requested a review from ranisalt April 25, 2023 00:40
EPuncker
EPuncker previously approved these changes Apr 30, 2023
View reviewed changes
DSpeichert
DSpeichert previously approved these changes Apr 30, 2023
View reviewed changes
MillhioreBT
MillhioreBT reviewed May 1, 2023
View reviewed changes
data/global.lua Outdated Show resolved Hide resolved
MillhioreBT
MillhioreBT reviewed May 1, 2023
View reviewed changes
src/luascript.cpp Outdated Show resolved Hide resolved
@DSpeichert DSpeichert merged commit 1972bc8 into otland:master May 12, 2023
@reyaleman reyaleman deleted the feature-highscores branch November 10, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omarcopires omarcopires omarcopires left review comments

@EPuncker EPuncker EPuncker approved these changes

@DSpeichert DSpeichert DSpeichert left review comments

@nekiro nekiro Awaiting requested review from nekiro

@MillhioreBT MillhioreBT Awaiting requested review from MillhioreBT

@ranisalt ranisalt Awaiting requested review from ranisalt

Assignees
No one assigned
Labels
feature New feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reyaleman @ranisalt @DSpeichert @EPuncker @omarcopires @MillhioreBT