Add extra & pedantic warnings and fix the code #4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPuncker
previously approved these changes
Jun 21, 2023
ranisalt
changed the title
|
Couldn't fix only 1 thing at once, so I added all warnings recommended by Jason Turner (except for -Wshadow, we do a LOT of that) |
EPuncker
approved these changes
Jun 26, 2023
MillhioreBT
approved these changes
Jun 27, 2023
Tofame
added a commit
to Tofame/TMS
that referenced
this pull request
Sep 27, 2023
otland/forgottenserver#4491 Added commit by Ranisalt. Should fix fmt compilation issue.
CyberfoxStudios
pushed a commit
to CyberfoxStudios/forgottenserver
that referenced
this pull request
Apr 20, 2024
* Remove discarded qualifiers in return types * Add more warnings and fix underlying enums
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Issues addressed: added -Wextra and, with that, found a few qualifiers that are discarded because adding
constto a primitive return type is useless.