Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MYSQL_OPT_RECONNECT deprecation warning #4626

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Remove MYSQL_OPT_RECONNECT deprecation warning #4626

merged 1 commit into from
Mar 14, 2024

Conversation

amatria
Copy link
Contributor

@amatria amatria commented Feb 5, 2024

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

This PR removes the following deprecation warning: WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version. This PR fixes a race condition that may occur in Database::beginTransaction() too.

Issues addressed: #4624

@EPuncker EPuncker linked an issue Feb 6, 2024 that may be closed by this pull request
EPuncker
EPuncker previously approved these changes Feb 6, 2024
src/database.cpp Dismissed Show dismissed Hide dismissed
src/database.cpp Fixed Show fixed Hide fixed
This commit removes the following deprecation warning:

WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a
future version

This commit fixes a race condition that may occur in
Database::beginTransaction() too.
@Zbizu
Copy link
Contributor

Zbizu commented Feb 8, 2024

thoughts on using goto statement in this code?

Copy link
Member

@DSpeichert DSpeichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goto was already used in the database code previously, so it's not a new concern.

@EPuncker EPuncker merged commit d4a0ce9 into otland:master Mar 14, 2024
19 checks passed
@amatria amatria deleted the fix/removeMySQLDeprecationWarning branch March 14, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated MySQL feature (MYSQL_OPT_RECONNECT)
5 participants