Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
This new method would help us know if the datatype belongs to a specific class.
Although we can do the raw comparison using the
getmetatable
function, it seems more intuitive to have this method with the nameisClass
Cases in which it can be useful:
isTile
method, because if it is a player or a container this method does not exist, but in the opposite case if you want to know if the cylinder is a player you can useisPlayer
, but if the cylinder happens to be a tile there will be an error becauseisPlayer
does not existExample
The other option would be to add all the methods corresponding to all the classes:
isTile, isPlayer, isCreature, isMonster, isItem, isContainer, isTeleport, isNpc
and their respective get
getTile, getPlayer, getCreature, getMonster, getItem, getContainer, getTeleport, getNpc
Issues addressed: Nothing!