Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fixes bug when player asks to withdraw a string ex; "withdraw" "x" #4732

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

Coldensjo
Copy link
Contributor

If you say "withdraw" "asjdhajsdhajsd" to the banker you will get this error. This PR should fix it.

Jun 04 07:29:31 Ironcore gdb[1007034]: Lua Script Error: [Npc interface]
Jun 04 07:29:31 Ironcore gdb[1007034]: data/npc/scripts/Suzy.lua:onCreatureSay
Jun 04 07:29:31 Ironcore gdb[1007034]: data/npc/lib/npc.lua:122: bad argument #1 to 'sub' (number expected, got nil)
Jun 04 07:29:31 Ironcore gdb[1007034]: stack traceback:
Jun 04 07:29:31 Ironcore gdb[1007034]: [C]: at 0x55555560ff80
Jun 04 07:29:31 Ironcore gdb[1007034]: [C]: in function 'sub'
Jun 04 07:29:31 Ironcore gdb[1007034]: data/npc/lib/npc.lua:122: in function 'getMoneyCount'
Jun 04 07:29:31 Ironcore gdb[1007034]: data/npc/scripts/Suzy.lua:140: in function 'callback'
Jun 04 07:29:31 Ironcore gdb[1007034]: data/npc/lib/npcsystem/npchandler.lua:413: in function 'onCreatureSay'
Jun 04 07:29:31 Ironcore gdb[1007034]: data/npc/scripts/Suzy.lua:10: in function <data/npc/scripts/Suzy.lua:10>

Copy link
Contributor

@EvilHero90 EvilHero90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was already tested

@EvilHero90 EvilHero90 added this to the 1.6 milestone Jun 4, 2024
@EvilHero90 EvilHero90 merged commit e9b6383 into otland:master Jun 4, 2024
5 checks passed
@EPuncker
Copy link
Contributor

EPuncker commented Jun 4, 2024

yo lets stick to tabs for Lua files indentation please 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants