Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GHA test workflow #17

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Implement GHA test workflow #17

merged 2 commits into from
Apr 4, 2022

Conversation

sondrelg
Copy link
Contributor

@sondrelg sondrelg commented Feb 25, 2022

Relates to #14

@sondrelg sondrelg mentioned this pull request Feb 25, 2022
@sondrelg sondrelg changed the title chore: Add GHA test workflow Implement GHA test workflow Feb 25, 2022
@sondrelg sondrelg requested a review from klette March 2, 2022 08:03
Base automatically changed from sondrelg/deprecate to master April 4, 2022 12:55
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 4, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.11%.

Quality metrics Before After Change
Complexity 1.55 ⭐ 1.55 ⭐ 0.00
Method Length 42.18 ⭐ 42.27 ⭐ 0.09 👎
Working memory 6.24 🙂 6.19 ⭐ -0.05 👍
Quality 83.63% 83.74% 0.11% 👍
Other metrics Before After Change
Lines 1295 1295 0
Changed files Quality Before Quality After Quality Change
netsgiro/objects.py 78.14% ⭐ 78.14% ⭐ 0.00%
netsgiro/records.py 81.01% ⭐ 81.42% ⭐ 0.41% 👍
tests/test_record_parsing.py 89.68% ⭐ 89.73% ⭐ 0.05% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
netsgiro/records.py TransactionAmountItem2.to_ocr 13 🙂 114 🙂 21 ⛔ 41.91% 😞 Extract out complex expressions
netsgiro/objects.py Transaction.from_records 3 ⭐ 115 🙂 21 ⛔ 51.17% 🙂 Extract out complex expressions
netsgiro/objects.py Assignment.from_records 7 ⭐ 124 😞 11 😞 57.09% 🙂 Try splitting into smaller methods. Extract out complex expressions
netsgiro/records.py AssignmentEnd.to_ocr 8 ⭐ 51 ⭐ 15 😞 60.60% 🙂 Extract out complex expressions
netsgiro/objects.py Transaction.to_records 1 ⭐ 103 🙂 14 😞 60.98% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sondrelg sondrelg merged commit 15f03ca into master Apr 4, 2022
@sondrelg sondrelg deleted the sondrelg/github-actions branch April 4, 2022 12:55
@sondrelg sondrelg mentioned this pull request Apr 4, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants