Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a find-blunders method #148

Merged
merged 5 commits into from
Nov 28, 2020
Merged

Add a find-blunders method #148

merged 5 commits into from
Nov 28, 2020

Conversation

artasparks
Copy link
Member

This PR fleshes out the FindBlunders method. It's not very configurable, but it does work end-to-end

Example test-run:

kashomon@Joshs-Air:~/inprogress/clamshell (blunders)$ go run katalyze/main.go --config=katalyze/testdata/analysis_example.cfg --model=katalyze/testdata/g170e-b10c128-s1141046784-d204142634.bin.gz katalyze/testdata/example-game.sgf
I1125 21:36:17.982544   83641 katago.go:68] Starting Katago analyzer
I1125 21:36:17.982660   83641 katago.go:69] Using model "katalyze/testdata/g170e-b10c128-s1141046784-d204142634.bin.gz"
I1125 21:36:17.982685   83641 katago.go:70] Using gtp config "katalyze/testdata/analysis_example.cfg"
I1125 21:36:25.707929   83641 katago.go:87] Katago Startup Complete
I1125 21:36:25.707978   83641 main.go:103] using files [katalyze/testdata/example-game.sgf]
I1125 21:36:25.708011   83641 main.go:105] Processing file "katalyze/testdata/example-game.sgf"
I1125 21:36:39.888000   83641 main.go:126] Finished processing file "katalyze/testdata/example-game.sgf"
I1125 21:36:39.888056   83641 main.go:133] Finished adding to game for file "katalyze/testdata/example-game.sgf"
I1125 21:36:39.888253   83641 main.go:146] Found Positions: [.0:64 .0:72 .0:80 .0:86 .0:92 .0:96 .0:100 .0:108 .0:122 .0:124 .0:134 .0:138]
I1125 21:36:39.888303   83641 katago.go:196] Shutting down Katago analyzer

Some miscellaneous changes:

  • Make a treepath-clone helper
  • Add better input-validation for katalyze main.go
  • Fix flag: analysisThreads => analysis_threads

@artasparks artasparks requested a review from a team as a code owner November 26, 2020 05:38
@artasparks artasparks requested review from a team, mhoak and TrevorPeters and removed request for a team November 26, 2020 05:38
Copy link
Member

@mhoak mhoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It might be nice for FindBlunders to return something that has treepath and point-value of blunders. That way we can start to understand if there is any correlation between point-value and usefulness of problems.

@artasparks
Copy link
Member Author

It might be nice for FindBlunders to return something that has treepath and point-value of blunders.

That's a good idea. Filed #155

@artasparks artasparks merged commit 1e1bd8a into otrego:master Nov 28, 2020
@artasparks artasparks deleted the blunders branch November 28, 2020 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants