-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Heartbeat Messages #49
Comments
What are the open questions for this issue? |
@olabini The behavior of the 'IGNORE_UNREADABLE' is not correctly defined on otrv3 spec, but it is defined over libotr3. Some TLVs on libotr3 have this flag set even though it is not 'specifically' defined as so on the spec. This was a cause of discussion on the past. So, I was proposing to double check this with Dave Goulet or DrWhax. |
Ah, I see. We should definitely define it, since it's part of the messages. |
Apparently, the heartbeat messages test is now failing randomly and causing memory leaks on the process. This could have been something that was there from the beginning but just started showing. There the error:
The mem leak:
|
This is just waiting for some comments, so I'm closing this now. |
Why
As we are currently implementing the revision number 2 of the OTRv4 specification, we need to correctly implement heartbeat messages.
Reference
The current implementation seems not to scale to work with a client.
See "Data Exchange" section, second paragraph, and "Receiving a Data Message" section for reference around heartbeat messages
For further information, check issue #24
Tasks
otrl_base64_otr_decode
function).Open questions
The text was updated successfully, but these errors were encountered: