Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spinner to plugin API #18

Open
otsaloma opened this issue Mar 31, 2023 · 0 comments · May be fixed by #21
Open

Add spinner to plugin API #18

otsaloma opened this issue Mar 31, 2023 · 0 comments · May be fixed by #21

Comments

@otsaloma
Copy link
Owner

For the UI, maybe we could change the search icon next to the input be a spinner when something is running a bit longer. For the plugin code that could look something like

with self.spinner():
    result = self.google_translate(text, src, dest)

If that looks useful, I could look into that.

Originally posted by @otsaloma in #17 (comment)
otsaloma added a commit that referenced this issue Sep 10, 2023
@otsaloma
Add context managers to use a loading icon
28365bd 
This is a bit simpler than Gtk.Spinner, which doesn't seem to actually
spin if some code is blocking. Some kind of an async dance would
probably be required to make that work as intended.

There's a bizarre need for a tiny sleep here for the icon to actually
change. It could be that the 1/100 s that is enough on my system might
not be enough on someone else's system.

Closes #18
@otsaloma otsaloma linked a pull request Sep 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add optional loading indicator (WIP) otsaloma/catapult
1 participant
@otsaloma