Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for reading attributes from MusicXML files #25

Closed
otsob opened this issue Dec 6, 2018 · 0 comments
Closed

Add support for reading attributes from MusicXML files #25

otsob opened this issue Dec 6, 2018 · 0 comments
Assignees
@otsob

Comments

@otsob
Copy link
Owner

otsob commented Dec 6, 2018 •
edited
Loading

In order to read attributes (composer name etc) from MusicXML input,
as a user,
I want there to be support for reading the attributes from a MusicXML file.

Acceptance criteria:

  • The composition title can be read from MusicXML and filled into the returned score object
  • The composer field can be read from MusicXML and filled into the returned score object
  • The arranger field can be read from MusicXML and filled into the returned score object
  • Each part in the returned score object has the full part name read from the MusicXML input
  • Each part in the returned score object has the abbreviated part name read from the MusicXML input
@otsob otsob self-assigned this May 15, 2019
otsob added a commit that referenced this issue May 15, 2019
@otsob
Issue #25: Remove year attribute because it is not supported
967702f
otsob added a commit that referenced this issue May 15, 2019
@otsob
Issue #25: Add reading of score attributes
997967d 
Add reading of composition title, composer, an arranger.
otsob added a commit that referenced this issue May 16, 2019
@otsob
Issue #25: Refactor part list reading to use DocHelper
d2681ae
otsob added a commit that referenced this issue May 16, 2019
@otsob
Issue #25: Add reading of part attributes to MusicXmlReaderDom
8a75720 
Add reading of part name and abbreviated part name from MusicXml.
@otsob otsob mentioned this issue May 16, 2019
Merged
otsob added a commit that referenced this issue May 17, 2019
@otsob
Issue #25: Add attribute for handling movement title
6056c17
otsob added a commit that referenced this issue May 17, 2019
@otsob
Issue #25: Add reading of score and part attributes
e264d18 
Add reading of
* composition title
* composer name
* arranger name
* movement title
* part name
* abbreviated part name

Update tests to check for movement title instead of
title in those cases where the title of the score
uses the movement title field.
otsob added a commit that referenced this issue May 17, 2019
@otsob
Merge pull request #102 from otsob/issue#25
c31ab3c 
Issue #25: Add reading of score and part attributes to MusicXML reader

Adds support for reading:
Score title
Movement title
Composer
Arranger
Part name
Abbrebiated part name
from MusicXML.
@otsob otsob closed this as completed May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otsob otsob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@otsob