Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for articulations that affect multiple notes #29

Closed
otsob opened this issue Dec 6, 2018 · 0 comments
Closed

Add support for articulations that affect multiple notes #29

otsob opened this issue Dec 6, 2018 · 0 comments
Assignees
@otsob

Comments

@otsob
Copy link
Owner

otsob commented Dec 6, 2018 •
edited
Loading

In order to handle articulations that affect multiple notes (legato, glissando),
as a user,
I want there to be an interface/class for handling multinote articulations.

Acceptance criteria:

  • There is a class or interface that represents multinote articulations
  • There is a way to access multinote articulations through notation objects
  • NoteBuilder has functionality for adding multi note articulations.
  • MultiNoteArticulations and ties affect the equality of Note instances
  • MultiNoteArticulations and ties affect the hashCode of Note instances
@otsob otsob self-assigned this Dec 26, 2018
@otsob otsob mentioned this issue Dec 31, 2018
Closed
@otsob otsob removed their assignment Mar 10, 2019
@otsob otsob self-assigned this Mar 19, 2019
otsob added a commit that referenced this issue Mar 22, 2019
@otsob
Issue #29: Clean up NoteBuilderTest
ad639e0 
Remove author name from copyright.
Clean up imports.
Remove unused variable.
otsob added a commit that referenced this issue Mar 22, 2019
@otsob
Issue #29: Finish up class for representing articulation that affect …
7fe7213 
…multiple notes

Add tests also.
otsob added a commit that referenced this issue Mar 22, 2019
@otsob
Issue #29: Rename multi note articulation to linked articulations
0a93834 
Remove method from Note that will no longer be a part of the classes
interface.
otsob added a commit that referenced this issue Mar 22, 2019
@otsob
Issue #29: Clean up NoteTest
5e7420e
otsob added a commit that referenced this issue Mar 22, 2019
@otsob
Issue #29: Add linked articulations to Note
64a4c59
otsob added a commit that referenced this issue Mar 22, 2019
@otsob
Issue #29: Add access to linked articulations to Note
2e0de9c
otsob added a commit that referenced this issue Mar 22, 2019
@otsob
Issue #29: Add access to linked articulations to Note
8a03127
otsob added a commit that referenced this issue Mar 22, 2019
@otsob
Issue #29: Make Note equality depend on linked articulations
91fd05c 
Add test and update other tests to take the new equality
definition into account.
otsob added a commit that referenced this issue Mar 24, 2019
@otsob
Issue #29: Refactor articulations getter to return Collection
ed8485c
otsob added a commit that referenced this issue Mar 24, 2019
@otsob
Issue #29; Add getter for all linked articulations
6472bea 
Improve documenatation to mention that the returned
collection is ummodifiable.
otsob added a commit that referenced this issue Mar 24, 2019
@otsob
Issue #29: Add getter for linked articulation belonging to given marking
e848b37
otsob added a commit that referenced this issue Mar 24, 2019
@otsob
Issue #29: Add method for iterating through the following notes
968e586 
Add a method that can be used for getting an iterable that can be used for
iterating through all notes belonging to the same marking that occur
after the linked articulation.
otsob added a commit that referenced this issue Mar 24, 2019
@otsob
Issue #29: Add getter for linked articulation belonging to given marking
51f402b
otsob added a commit that referenced this issue Mar 24, 2019
@otsob
Issue #29: Add method for iterating through the following notes
b4a6869 
Add a method that can be used for getting an iterable that can be used for
iterating through all notes belonging to the same marking that occur
after the linked articulation.
otsob added a commit that referenced this issue Mar 24, 2019
@otsob
Issue #29: Add method for getting all notes affected by a given marking
15efd09
otsob added a commit that referenced this issue Mar 25, 2019
@otsob
Issue #29: Rename Linked articulation to Marking connection
188a047 
With this name the code will be a lot clearer and easier to
understand as Marking is the main object when handling
markings.
otsob added a commit that referenced this issue Mar 25, 2019
@otsob
Issue #29: Rename Linked articulation to Marking connection
804add2 
With this name the code will be a lot clearer and easier to
understand as Marking is the main object when handling
markings.
otsob added a commit that referenced this issue Mar 25, 2019
@otsob
Issue #29: Add method for getting notes affected by a marking
ffe1771
otsob added a commit that referenced this issue Mar 25, 2019
@otsob
Issue #29: Rename Linked articulation to Marking connection
9bd4ccf 
With this name the code will be a lot clearer and easier to
understand as Marking is the main object when handling
markings.
otsob added a commit that referenced this issue Mar 25, 2019
@otsob
Issue #29: Add method for getting notes affected by a marking
ae74bb7
otsob added a commit that referenced this issue Mar 25, 2019
@otsob
Issue #29: Remove copying markings from NoteBuilder copy constructor
2e9786b
otsob added a commit that referenced this issue Mar 25, 2019
@otsob
Issue #29: Rename Linked articulation to Marking connection
63337ca 
With this name the code will be a lot clearer and easier to
understand as Marking is the main object when handling
markings.
otsob added a commit that referenced this issue Mar 25, 2019
@otsob
Issue #29: Add method for getting notes affected by a marking
a82771a
otsob added a commit that referenced this issue Mar 25, 2019
@otsob
Issue #29: Remove copying markings from NoteBuilder copy constructor
af4c0c3
otsob added a commit that referenced this issue Mar 26, 2019
@otsob
Issue #29: Add support for adding markings to note builder
24119b3
otsob added a commit that referenced this issue Mar 26, 2019
@otsob
Issue #29: Add circular marking dependency detection
e150973 
Check for circular dependency when building connected builders.
Add test cases for circular dependency and multiple markings.
@otsob otsob mentioned this issue Mar 26, 2019
Merged
otsob added a commit that referenced this issue Mar 27, 2019
@otsob
Issue #29: Rename Linked articulation to Marking connection
107e5d6 
With this name the code will be a lot clearer and easier to
understand as Marking is the main object when handling
markings.
otsob added a commit that referenced this issue Mar 27, 2019
@otsob
Issue #29: Add method for getting notes affected by a marking
f6b60da
otsob added a commit that referenced this issue Mar 27, 2019
@otsob
Issue #29: Remove copying markings from NoteBuilder copy constructor
0f46c9e
otsob added a commit that referenced this issue Mar 27, 2019
@otsob
Issue #29: Add support for adding markings to note builder
cd78da3
otsob added a commit that referenced this issue Mar 27, 2019
@otsob
Issue #29: Add circular dependency detection to note builder
d15d7aa 
Check for circular dependency when building connected builders.
Add test cases for circular dependency and multiple markings.
otsob added a commit that referenced this issue Mar 27, 2019
@otsob
Merge pull request #87 from otsob/issue#29
69f55da 
Add support for markings that affect multiple notes (issue #29).

* Add markings that affect multiple notes (slur, glissando, different line markings in the future).
* Add access to markings in the Note class.
* Add support in NoteBuilder for markings.
* Add tests for new functionality.
@otsob otsob closed this as completed Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otsob otsob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@otsob