Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading multinote markings from MusicXML #32

Closed
otsob opened this issue Dec 6, 2018 · 0 comments
Closed

Add support for reading multinote markings from MusicXML #32

otsob opened this issue Dec 6, 2018 · 0 comments
Assignees

Comments

@otsob
Copy link
Owner

otsob commented Dec 6, 2018

In order to read multinote markings from MusicXML
as a user
I want MusicXML reading to correctly add multinote markings to Scores

Acceptance criteria:

  • Legato markings can be read
  • Glissando markings can be read
@otsob otsob changed the title Add support for reading multinote articulations from MusicXML Add support for reading multinote markings from MusicXML Mar 26, 2019
@otsob otsob self-assigned this May 18, 2019
otsob added a commit that referenced this issue May 24, 2019
Use same methods for reading scores in all tests where
possible.
Do not unnecessarily validate scores that can be expected to
be valid.
otsob added a commit that referenced this issue May 24, 2019
Change tie beginning container to have a more
generic name so that it can sensibly be used for
other connections between notes.
otsob added a commit that referenced this issue May 24, 2019
Add support for reading markings that span multiple notes within
the same voice in the same part.
otsob added a commit that referenced this issue May 24, 2019
Trying to read articulations from other types of nodes
is unnecessary and leads to logging warnings.
otsob added a commit that referenced this issue May 24, 2019
Issue #32: Add support for reading markings from MusicXML

Adds support for reading markings (slurs, glissando) from MusicXML.
The implementation only supports markings that occur between notes in the same voice.
Handling of slurs that cross parts and voices is more complex and is to be handled in issue #109
@otsob otsob closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant