Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the placement and style of notation iterators #34

Closed
otsob opened this issue Dec 6, 2018 · 0 comments
Closed

Unify the placement and style of notation iterators #34

otsob opened this issue Dec 6, 2018 · 0 comments
Assignees
@otsob

Comments

@otsob
Copy link
Owner

otsob commented Dec 6, 2018 •
edited
Loading

In order to have clear package structure,
as a user,
I want all iterators that iterate over notation objects to be placed in the same package

Acceptance criteria:

  • All iterators are defined in the iterators package (as interfaces or concrete classes, implementations can be in other packages)
  • All iterators implement the standard Java Iterator interface
@otsob otsob changed the title Unify the placement of iterators Unify the placement and style of notation iterators Dec 6, 2018
@otsob otsob self-assigned this Apr 5, 2019
otsob added a commit that referenced this issue Apr 5, 2019
@otsob
Issue #34: Fix typo in javadoc
6cfd431
otsob added a commit that referenced this issue Apr 5, 2019
@otsob
Issue #34: Add static factory method for pickup measures
d1ab352
otsob added a commit that referenced this issue Apr 5, 2019
@otsob
Issue #34: Move Measure iterator to the iterators package
e5feff9
otsob added a commit that referenced this issue Apr 5, 2019
@otsob
Issue #34: Move Part iterator to iterators package
df44661 
Make implementations private.
otsob added a commit that referenced this issue Apr 5, 2019
@otsob
Issue #34: Clean up redundant javadoc
285a26c 
The methods to what the iterator interface specifies
so any additional javadoc is unnecessary
otsob added a commit that referenced this issue Apr 6, 2019
@otsob
Issue #34: Fix typo in javadoc
ff8e5da
otsob added a commit that referenced this issue Apr 6, 2019
@otsob
Issue #34: Add static factory method for pickup measures
f6a6d44
otsob added a commit that referenced this issue Apr 6, 2019
@otsob
Issue #34: Move Measure iterator to the iterators package
60255aa
otsob added a commit that referenced this issue Apr 6, 2019
@otsob
Issue #34: Move Part iterator to iterators package
30e5131 
Make implementations private.
otsob added a commit that referenced this issue Apr 6, 2019
@otsob
Issue #34: Clean up redundant javadoc
cc3c1b7 
The methods to what the iterator interface specifies
so any additional javadoc is unnecessary
@otsob otsob closed this as completed Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otsob otsob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@otsob