Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SIATECHF #44

Closed
otsob opened this issue Dec 6, 2018 · 0 comments
Closed

Implement SIATECHF #44

otsob opened this issue Dec 6, 2018 · 0 comments
Assignees
@otsob

Comments

@otsob
Copy link
Owner

otsob commented Dec 6, 2018 •
edited
Loading

In order to find repeated patterns in scores,
as a user,
I want there to be an implementation of the SIATECHF algorithm

Acceptance criteria:
@otsob otsob mentioned this issue Aug 19, 2019
Closed
@otsob otsob self-assigned this Aug 19, 2019
@otsob otsob changed the title Implement SIATECH Implement SIATECHF Aug 19, 2019
otsob added a commit that referenced this issue Oct 2, 2019
@otsob
Issue #44: Rename pattern_discovery package to just discovery
6f783ce
otsob added a commit that referenced this issue Oct 2, 2019
@otsob
Issue #44: Add interface for Pattern discovery results
5cabebd
otsob added a commit that referenced this issue Oct 2, 2019
@otsob
Issue #44: Remove obsolete test
1ee2549 
The test was unfinished anyway.
otsob added a commit that referenced this issue Oct 2, 2019
@otsob
Issue #44: Improve NoteEventVector
4356c22 
* Handle pitch and voice as integers
* Remove saving Position in NoteEventVector, this needs to be handled differently.
* Use rounded offset for comparisons and hashcode.
* Rename RandomMultiplierProvider and add unit test
otsob added a commit that referenced this issue Oct 2, 2019
@otsob
TODO: Finish up
e67e82a 
Issue #44: Implement PointSet representation of Score
otsob added a commit that referenced this issue Oct 5, 2019
@otsob
Issue #44: Implement PointSet representation of Score
9f98397 
Finish up the point set implementation and add tests.
otsob added a commit that referenced this issue Oct 5, 2019
@otsob
Issue #44: Implement PointPattern
a9a0c9b
otsob added a commit that referenced this issue Oct 5, 2019
@otsob
Issue #44: Implement translational equivalence class
c712081
otsob added a commit that referenced this issue Oct 15, 2019
@otsob
TODO: Finish this
b6f14f5 
Issue #44: Implement SIATECHF
otsob added a commit that referenced this issue Oct 16, 2019
@otsob
TODO: Finish this
e98c680 
Issue #44: Implement SIATECHF

* Implement the SIATECHF algorithm
* Add access to SIATECHF results as actual patterns
  in notation in GeometricPatternDiscovery

TODO: Add tests for GeometricPatternDiscovery
TODO: Add text labels to discovered patterns so that
they can be located from the score
otsob added a commit that referenced this issue Oct 17, 2019
@otsob
Issue #44: Make copy of positions set to avoid side effects
fd92c9b 
Also make the returned set unmodifiable
otsob added a commit that referenced this issue Oct 17, 2019
@otsob
Issue #44: Implement SIATECHF
145d748 
* Implement the SIATECHF algorithm
* Add access to SIATECHF results as actual patterns
  in notation in GeometricPatternDiscovery
* Implement geometric pattern discovery
* Add name for pattern based on positions when
  getting pattern based on position
otsob added a commit that referenced this issue Oct 17, 2019
@otsob
Issue #44: Implement SIATECHF
1e59fc2 
* Implement the SIATECHF algorithm
* Add access to SIATECHF results as actual patterns
  in notation in GeometricPatternDiscovery
* Implement geometric pattern discovery
* Add name for pattern based on positions when
  getting pattern based on position
@otsob otsob mentioned this issue Oct 17, 2019
Merged
otsob added a commit that referenced this issue Oct 20, 2019
@otsob
Issue #44: Implement SIATECHF
163723f 
* Implement the SIATECHF algorithm
* Add access to SIATECHF results as actual patterns
  in notation in GeometricPatternDiscovery
* Implement geometric pattern discovery
* Add name for pattern based on positions when
  getting pattern based on position
otsob added a commit that referenced this issue Oct 20, 2019
@otsob
Merge pull request #144 from otsob/issue#44
a5586ef 
Issue #44: Implement repeated pattern discovery with SIATECHF

* Implement all required classes for geometric repeated patterns discovery in music
* Add an implementation of the SIATECHF algorithm, that finds all occurrences of 
maximal translatable patterns whose compression ratio exceeds a given threshold
@otsob otsob closed this as completed Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otsob otsob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@otsob