Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create interface and implementation for monophonic patterns #5

Closed
otsob opened this issue Sep 21, 2018 · 0 comments
Closed

Create interface and implementation for monophonic patterns #5

otsob opened this issue Sep 21, 2018 · 0 comments
Assignees
@otsob

Comments

@otsob
Copy link
Owner

otsob commented Sep 21, 2018 •
edited
Loading

In order to handle monophonic musical patterns (motifs, segments of melodies, melodies etc.)
as a user
I want there to be an interface and implementation for handling polyphonic musical patterns

Acceptance criteria:

  • The monophonic pattern should provide at least basic equality comparisons:
    • equals
    • equals in pitch
    • equals in durations
    • is tranpositionally equivalent
  • The pattern implementation is immutable
  • There are unit tests for the pattern implementation
  • There is a builder class for creating patterns
@otsob otsob changed the title Create interface and implementation for handling monophonic patterns Create interface and implementation for monophonic patterns Sep 21, 2018
@otsob otsob self-assigned this Oct 16, 2018
@otsob otsob removed their assignment Nov 17, 2018
@otsob otsob self-assigned this May 29, 2019
otsob added a commit that referenced this issue May 29, 2019
@otsob
Issue #5: Remove unneeded author info
99bec1f
otsob added a commit that referenced this issue May 29, 2019
@otsob
Issue #5: Improve documentation to be more specific
b628c85
otsob added a commit that referenced this issue May 29, 2019
@otsob
Issue #5: Implement isMonophonic in Monphonic pattern
c2dacb3 
Enable related tests.
otsob added a commit that referenced this issue May 29, 2019
@otsob
Issue #5: Rename test method to be more descriptive
f253ebd
otsob added a commit that referenced this issue May 29, 2019
@otsob
Issue #5: Remove unneeded author info from Pattern
95cf158
otsob added a commit that referenced this issue May 29, 2019
@otsob
Issue #5: Remove unnecessary equals method from Pattern
0bf8bc5 
Use the default Object.equals instead.
otsob added a commit that referenced this issue May 29, 2019
@otsob
Issue #5: Add equals method implementation to MonophonicPattern
ca06b2d 
Enable the equals test and rename it.
Add default hashCode also.
otsob added a commit that referenced this issue May 29, 2019
@otsob
Issue #5: Add test about immutability
71d6b62
otsob added a commit that referenced this issue May 29, 2019
@otsob
Issue #5: Remove use of <code> tags from Pattern documentation
558d078
otsob added a commit that referenced this issue May 29, 2019
@otsob
Issue #5: Implement equalsInPitch in MonophonicPattern
05d15a2
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Shorten name to equalsEnharmonically in Pattern interface
f51d5f7
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Implement method for checking enharmonic equality of Monoph…
1c2f4ff 
…onic patterns
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Hide the monophonic implementation
39da316 
Patterns should be handled through the common interface
whether they are monophonic or polyphonic.
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Refactor MonophonicPatternTest to test through the interface
4dcceaf 
Ensure that tested instances are always of expected type, but
test them through the interface instead of implementation class.
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Remove equalsInOnsets method
9441faa 
This method is not needed for now.
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Implement method for checking enharmonic equality of Monoph…
ee58240 
…onic patterns
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Hide the monophonic implementation
e82f0cd 
Patterns should be handled through the common interface
whether they are monophonic or polyphonic.
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Refactor MonophonicPatternTest to test through the interface
6bb85b2 
Ensure that tested instances are always of expected type, but
test them through the interface instead of implementation class.
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Remove equalsInOnsets method
e68411d 
This method is not needed for now.
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Rename method to equalsInDurations
01d2d26 
The name equalsInRhythm was too ambiguous.
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Implement method for checking if patterns are equal in dura…
c22089a 
…tions
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Hide the monophonic implementation
e23b289 
Patterns should be handled through the common interface
whether they are monophonic or polyphonic.
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Refactor MonophonicPatternTest to test through the interface
4bf9dfc 
Ensure that tested instances are always of expected type, but
test them through the interface instead of implementation class.
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Remove equalsInOnsets method
175d955 
This method is not needed for now.
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Rename method to equalsInDurations
dc1fc3b 
The name equalsInRhythm was too ambiguous.
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Implement method for checking if patterns are equal in dura…
ad1e145 
…tions
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Rename method that checks for transpositional equivalence
82e5b32
otsob added a commit that referenced this issue Jun 1, 2019
@otsob
Issue #5: Implement method for checking for transpositional equivalence
539cb09
@otsob otsob mentioned this issue Jun 1, 2019
Merged
otsob added a commit that referenced this issue Jun 2, 2019
@otsob
Issue #5: Implement method for checking if patterns are equal in dura…
509e3ea 
…tions
otsob added a commit that referenced this issue Jun 2, 2019
@otsob
Issue #5: Rename method that checks for transpositional equivalence
f2f15da
otsob added a commit that referenced this issue Jun 2, 2019
@otsob
Issue #5: Implement method for checking for transpositional equivalence
ac837a0
otsob added a commit that referenced this issue Jun 2, 2019
@otsob
Merge pull request #114 from otsob/issue#5
48f2b05 
Issue #5: Implement monophonic pattern handling

Adds an implementation with tests for checking if monophonic patterns are equal in:
* pitch
* durations
* enharmonically in pitch
* transpositionally in pitch
otsob added a commit that referenced this issue Jun 4, 2019
@otsob
Issue #5: Remove unneeded author info from license header
d963a8c
otsob added a commit that referenced this issue Jun 4, 2019
@otsob
Issue #5: Add builder for monophonic patterns
5c5e4c7
otsob added a commit that referenced this issue Jun 4, 2019
@otsob
Issue #5: Add method for checking if builder is monophonic
5e99b78
otsob added a commit that referenced this issue Jun 4, 2019
@otsob
Merge pull request #115 from otsob/issue#5-pattern-builder
e303b35 
Issue #5: Add pattern builder

Implement pattern builder that can be used for building monophonic patterns.
@otsob otsob closed this as completed Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otsob otsob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@otsob