Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #39: Add common interface for reading files into Score objects #90

Merged
merged 3 commits into from
Mar 31, 2019

Conversation

MWargelin
Copy link
Collaborator

A new interface is added for reading music notation files into Score objects. The existing MusicXmlReader interface extends the new interface and overlap is removed from MusicXmlReader. By implementing MusicXmlReader, MusicXmlReaderDom also implements ScoreReader.

@MWargelin MWargelin requested a review from otsob March 31, 2019 15:31
@otsob
Copy link
Owner

otsob commented Mar 31, 2019

+2, looks good.

@otsob otsob merged commit 0330c5f into otsob:master Mar 31, 2019
@MWargelin MWargelin deleted the issue#39 branch March 31, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants