Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update progot #571

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Feature/update progot #571

merged 5 commits into from
Aug 14, 2024

Conversation

michalk8
Copy link
Collaborator

Remove some legacy code.

@michalk8 michalk8 added the misc label Aug 13, 2024
@michalk8 michalk8 self-assigned this Aug 13, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (a97c178) to head (9fad771).

Files Patch % Lines
src/ott/tools/progot.py 0.00% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files          72       72           
  Lines        7718     7718           
  Branches     1107     1106    -1     
=======================================
  Hits         6823     6823           
  Misses        744      744           
  Partials      151      151           
Files Coverage Δ
src/ott/tools/progot.py 29.37% <0.00%> (ø)

Copy link
Collaborator

@pkassraie pkassraie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

@michalk8 michalk8 merged commit 5bb44af into main Aug 14, 2024
12 checks passed
@michalk8 michalk8 deleted the feature/update-progot branch September 12, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants