Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stack_overflow for filtering a file #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

westpaddy
Copy link

The current implementation rarely raises the Stack_overflow exception for filtering some particular files. I encountered the situation with a file containing a rather long [[ ... ]] being parsed.

This fix replaces non-tail-recursive functions related to the problem with tail-recursive ones. I believe this fix causes minor performance issues for at least filtering files the current implementation can handle because only a short list is dealt with in such cases. The fix may be more efficient if we well understand the algorithm, though. For example, we can remove List.rev if a list used in the algorithm is order-irrespective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant