Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in-line YAMLs to EKS mini-tutorial, prevent conflicts with base netpol tutorial #131

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Add in-line YAMLs to EKS mini-tutorial, prevent conflicts with base netpol tutorial #131

merged 1 commit into from
Aug 31, 2023

Conversation

orishoshan
Copy link
Contributor

@orishoshan orishoshan commented Aug 31, 2023 •
edited
Loading

  • Added in-line YAMLs
  • Moved the all.yaml file for services to the tutorial's static dir, so that it doesn't change if someone changes the netpol tutorial
  • Change the namespace to otterize-tutorial-eks, so it doesn't conflict with the netpol tutorial

@orishoshan orishoshan changed the title Add YAML details to EKS mini-tutorial Add in-line YAMLs to EKS mini-tutorial, prevent conflicts with base netpol tutorial Aug 31, 2023
davidgs
davidgs approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@davidgs davidgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for doing this!

@davidgs davidgs merged commit 517e522 into main Aug 31, 2023
2 checks passed
@davidgs davidgs deleted the orisho/mini-tutorial-improvements branch August 31, 2023 12:16
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidgs davidgs davidgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orishoshan @davidgs