Remove references to SPIRE where no longer relevant #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about tutorials where we now need to add it, e.g. Kafka tutorials where you'd need it if you're not connecting to Cloud? For the Istio one, and perhaps others, we still have:
What is the right replacement for this? |
usarid
reviewed
Sep 10, 2023
usarid
reviewed
Sep 10, 2023
|
@usarid On your comment: In the PR that disabled SPIRE, we added instructions to enable SPIRE in the tutorials that need it. I'm removing the system requirements since they are incorrect. |
…github.com/otterize/docs into orisho/remove_irrelevant_references_to_spire
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, SPIRE was deployed by default. It is now no longer deployed by default, and this PR removes references to configuring it in tutorials where it is not used.