Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reading database ServerConfig credentials from k8s secrets #440

Merged
merged 15 commits into from
Jun 23, 2024
Merged

Support reading database ServerConfig credentials from k8s secrets #440

merged 15 commits into from
Jun 23, 2024

Conversation

amitlicht
Copy link
Contributor

@amitlicht amitlicht commented Jun 18, 2024 •
edited
Loading

Description

  • Support reading database credentials for PostgreSQL & MySQL, from a k8s secret, referenced by their database ServerConfig.
  • Implement backwards compatibility with existing database ServerConfigs, with fallback to plaintext username & password specified in the ServerConfig.
  • Call E2E tests workflow from https://github.com/otterize/helm-charts on build workflow

References

otterize/helm-charts#218
#440
otterize/credentials-operator#143
otterize/docs#243

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

@amitlicht amitlicht force-pushed the amitlicht/db_credentials_secrets branch 2 times, most recently from 9962cd4 to 4c17117 Compare June 20, 2024 10:22
@amitlicht amitlicht mentioned this pull request Jun 20, 2024
Merged
1 task
@amitlicht amitlicht force-pushed the amitlicht/db_credentials_secrets branch 3 times, most recently from fba5b52 to c4f74dd Compare June 20, 2024 12:42
@amitlicht amitlicht force-pushed the amitlicht/db_credentials_secrets branch from c4f74dd to 306300e Compare June 20, 2024 12:43
@amitlicht amitlicht force-pushed the amitlicht/db_credentials_secrets branch from e1d967f to 9aef463 Compare June 20, 2024 13:00
@amitlicht amitlicht force-pushed the amitlicht/db_credentials_secrets branch from 3ecdd21 to d1622cc Compare June 23, 2024 09:31
@amitlicht amitlicht marked this pull request as ready for review June 23, 2024 09:42
@amitlicht amitlicht mentioned this pull request Jun 23, 2024
Merged
2 tasks
@amitlicht amitlicht merged commit 27d9ebb into main Jun 23, 2024
13 of 14 checks passed
@amitlicht amitlicht deleted the amitlicht/db_credentials_secrets branch June 23, 2024 16:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evyatarmeged evyatarmeged evyatarmeged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amitlicht @evyatarmeged