You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just spot-checked muler provisioned with specutils 1.5 and astropy 5.0. Remarkably it appears to work right out of the box! It even works with gwcs 0.17.1, which was previously disallowed for our muler install because of issue #70 .
This ease of install is a good thing. It raises the issue of how to handle backwards compatibility. Should we demand that users upgrade to specutils 1.5, gwcs 0.17.1, and astropy 5? That may have some backwards breaking changes for folks. It also will probably break whatever conda environment they currently have.
On the other hand, how to we support some gwcs-specutils-astropy combinations and not others? Maybe the easiest thing to do is disallow gwcs 0.17.0, and all other astropy-specutils combos should just work? Not sure! I suppose we could add gwcs to our existing build matrix.
We may also want to write some guidance in the docs on how to make a fresh conda environment if you're upgrading to specutils.
By the way, the tests are only failing due to an experimental commit to the equivalent_width method.
The text was updated successfully, but these errors were encountered:
I just spot-checked muler provisioned with
specutils 1.5
andastropy 5.0
. Remarkably it appears to work right out of the box! It even works withgwcs 0.17.1
, which was previously disallowed for ourmuler
install because of issue #70 .This ease of install is a good thing. It raises the issue of how to handle backwards compatibility. Should we demand that users upgrade to specutils 1.5, gwcs 0.17.1, and astropy 5? That may have some backwards breaking changes for folks. It also will probably break whatever conda environment they currently have.
On the other hand, how to we support some
gwcs-specutils-astropy
combinations and not others? Maybe the easiest thing to do is disallowgwcs 0.17.0
, and all other astropy-specutils combos should just work? Not sure! I suppose we could addgwcs
to our existing build matrix.We may also want to write some guidance in the docs on how to make a fresh conda environment if you're upgrading to specutils.
By the way, the tests are only failing due to an experimental commit to the
equivalent_width
method.The text was updated successfully, but these errors were encountered: