Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with specutils 1.5 and astropy 5.0 #75

Closed
gully opened this issue Jan 25, 2022 · 1 comment
Closed

Compatibility with specutils 1.5 and astropy 5.0 #75

gully opened this issue Jan 25, 2022 · 1 comment

Comments

@gully
Copy link
Member

gully commented Jan 25, 2022

I just spot-checked muler provisioned with specutils 1.5 and astropy 5.0. Remarkably it appears to work right out of the box! It even works with gwcs 0.17.1, which was previously disallowed for our muler install because of issue #70 .

This ease of install is a good thing. It raises the issue of how to handle backwards compatibility. Should we demand that users upgrade to specutils 1.5, gwcs 0.17.1, and astropy 5? That may have some backwards breaking changes for folks. It also will probably break whatever conda environment they currently have.

On the other hand, how to we support some gwcs-specutils-astropy combinations and not others? Maybe the easiest thing to do is disallow gwcs 0.17.0, and all other astropy-specutils combos should just work? Not sure! I suppose we could add gwcs to our existing build matrix.

We may also want to write some guidance in the docs on how to make a fresh conda environment if you're upgrading to specutils.

By the way, the tests are only failing due to an experimental commit to the equivalent_width method.

@gully
Copy link
Member Author

gully commented Feb 28, 2022

I think our setup.py file may be misguided at the moment. It currently has install_requires with:

        "numpy",
        "scipy",
        # "astropy>=4.1,<5.0",
        "specutils",
        "pandas",
        "importlib_resources",
        "matplotlib",

We probably want to update it to:

        "numpy",
        "scipy",
        "astropy>=4.1",
        "specutils",
        "gwcs >=0.17.1",
        "pandas",
        "importlib_resources",
        "matplotlib",

That's what the new conda-forge requirement looks like.

@gully gully closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant