Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CI workflow #350

Closed
wants to merge 2 commits into from
Closed

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Jan 12, 2023

This PR:

  • gives a minor update to the CI workflow
  • unpins the matplotlib requirement

The goal of this PR is to get CI green again with the current matrix. In subsequent PRs we can prune down OS runs, then see about getting testing up and running for Python 3.11. However, numba is still not in available for 3.11 so that is another hurdle.

@jGaboardi jGaboardi self-assigned this Jan 12, 2023
@knaaptime
Copy link
Member

thanks for taking a look. On the mpl front, i think the blocker is proplot. Unpinning mpl will pass because we're not currently testing the plotting funcs, which should also change.

On one hand, I think the proplot fix is probably straightforward, so i'll take a look and see if i can send a PR the dev will merge, but taking a look at the issues/history, its not clear the project will be maintained much, so might also be time to refactor and remove. I like proplots aesthetics and it makes some stuff a lot easier, but its not absolutely critical

@knaaptime
Copy link
Member

if/until we decide to refactor proplot out, we need to keep the matlotlib pin (because the pinning is done incorrectly in proplot)

@jGaboardi
Copy link
Member Author

@knaaptime This is now fixed in geosnap, correct? We can close if so.

@knaaptime
Copy link
Member

yeah, i made proplot optional while its in flux, which was a bit easier than i thought (but will make it a bit harder to make nice figs).

you probably got a billion emails today as i figured this out, but one thing i had to do differently here than the pysal stack is use coverage run -m pytest otherwise it would refuse to see any lines as run (despite all the tests running through)

@knaaptime knaaptime closed this Oct 3, 2023
@jGaboardi jGaboardi deleted the remove_matplotlib_pin branch October 3, 2023 00:13
@jGaboardi jGaboardi mentioned this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants