-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from oof
to clap
#108
Conversation
Oh I forgot to update the tests.. |
I can help adding completions and help2man man pages once this gets merged |
Clap also has clap_generate which can be used but I'm not really sure what the best practices are |
Yes that's what I meant to use, with a |
Can't believe I just took a nap and this is already done.
No problem! The small changes in It's awesome, thanks for the effort, It's a |
Remembering all the different commands to compress and decompress all the different formats can be a huge pain and ouch is the first project I've seen that address this issue on the cli so I really want to help make it as good as possible |
I'm glad we feel the same about it :D. |
Ok, I found a problem:
I hate seeing our names stand out in the Later we can consider adding it to the man pages, if necessary, @vrmiguel you agree on replacing it by the repository link? |
Also iirc |
I believe you are correct but I wonted to be explicit since it's only a couple of times anyway |
this also creates another problem: clap uses |
@figsoda you mean like, if one is detected and the other is not? (like |
yes |
Status update, pending:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems great! Thanks!
I like our current help message better than the one clap
gives us but I believe we can improve it later on using some template
5327286
to
b1015b1
Compare
b1015b1
to
e17eb95
Compare
It's a single commit with many changes, sorry about that but I wasn't sure how to break it down.
Here are the help messages for reference:
This closes #105