Truncate long messages in the progress bar #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's something weird going on
|
|
Can you upload the file you're using because I can't reproduce this behavior. |
|
Aside: I just noticed something, ouch fails to compress if a directory contains a broken symlink |
|
Also which terminal are you using? |
|
I can reproduce, I'll see if I can figure it out |
|
I think it should be fixed now |
|
I'll run some more manual tests before merging. |
|
I noticed that paths that are printed when extracting from zip or tar are canonicalized, I think we need another pr to fix that which would improve the ux even more. |
marcospb19
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the path is too long the progress bar wraps around, and starts spamming messages in new lines.
By using,
wide_msg, long messages are automatically truncated by indicatf.