-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support snappy format #215
Conversation
Nice, does the Snappy format has any MIME bytes to be add to the tests? |
yes, application/x-snappy-framed, but infer doesn't support it |
For reference, we have some MIME checks implemented here: Lines 65 to 121 in bafc2d3
So, this could probably be reused in our tests? If you wish to, I can merge this as it is, and then you can create an issue for covering the rest of it. Or, you can try to solve everything in this PR. |
I thought about reusing it by checking the warnings generated by the program, but #220 (just opened btw) might cause tests to fail I don't plan on addressing this in this pull request |
closes #202
Also removed remaining mentions of incorrect lz extensions that wasn't removed in #198