-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add further testing to oof #27
Conversation
Looking great, I will just request one change before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So i'm attempting to create this setup function you asked me. How would we tackle this compile error?
filter_flags
needs a reference for flags_info
and we cannot return them from within the function.
How would you solve this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added further testing. Getting weird compiler complains tho. I think it has to do with this matches macro
So i did a little refactor in the assert approach and added |
You're doing good! If you have finished let me know it is ready for merging. For that we usually mark the PR as draft, and then unmark when it's ready, so I'll be marking your PR as draft here. (feel free to add more comments for any questions) |
I think we're set. Every error variant is now covered. |
It is possible that If you want to keep an eye on I created some other issues because it was a mess, if you need any mentoring again, don't be afraid to ask. This PR is looking very good, thank you so much for the contribution. |
.