Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not overwriting a folder when compressing #295

Merged
merged 2 commits into from
Oct 16, 2022
Merged

Conversation

marcospb19
Copy link
Member

@marcospb19 marcospb19 commented Oct 16, 2022

And also rename ask_to_create_file function.

$ mkdir a.tar
$ echo a > a.txt
$ ouch compress a.txt a.tar
Do you want to overwrite 'a.tar'? [Y/n] 
[ERROR] failed to create file `a.tar`

@marcospb19
Copy link
Member Author

Very small refac, the functions in the question.rs suffer from bad naming because most of them do more than one thing, so it's weird to give them a proper name.

Copy link
Member

@figsoda figsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcospb19
Copy link
Member Author

This also solves a bug, so I will rename the PR and add it to the CHANGELOG as a bug fix.

@marcospb19 marcospb19 marked this pull request as draft October 16, 2022 00:20
@figsoda
Copy link
Member

figsoda commented Oct 16, 2022

btw, now ci takes a long time for the cross compilations to complete, so you might want to skip ci in the changelog update if you want to save some time

@marcospb19 marcospb19 changed the title Remove explicit unwrap Fix not overwriting a folder when compressing Oct 16, 2022
@marcospb19 marcospb19 marked this pull request as ready for review October 16, 2022 00:40
@marcospb19 marcospb19 merged commit 79597f4 into main Oct 16, 2022
@marcospb19 marcospb19 deleted the remove-unwrap branch October 16, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants