Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly detect if we are compressing a partially compressed file #91

Conversation

SpyrosRoum
Copy link
Contributor

This closes #54

Copy link
Member

@marcospb19 marcospb19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just requesting some small changes.

src/commands.rs Outdated Show resolved Hide resolved
src/commands.rs Outdated Show resolved Hide resolved
src/commands.rs Outdated Show resolved Hide resolved
@marcospb19 marcospb19 force-pushed the properly-compress-partially-compressed-files branch from 3f35a6c to 05f82d3 Compare October 15, 2021 08:46
@marcospb19
Copy link
Member

marcospb19 commented Oct 15, 2021

(Force pushed to fix typo in commit message.)

I won't merge right now because we have some configuration set wrong in the repo, which wants me to squash your commits, I'll wait for @vrmiguel to wake up and change that, then merge.

Thanks for the contribution!

@marcospb19 marcospb19 added the hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event label Oct 15, 2021
@marcospb19 marcospb19 merged commit 2c5a57c into ouch-org:master Oct 15, 2021
@SpyrosRoum SpyrosRoum deleted the properly-compress-partially-compressed-files branch October 15, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly compress files which are already partially compressed
2 participants