Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] misc nft-editions bugs/improvements #13

Merged
merged 15 commits into from
Oct 14, 2021
Merged

[fix] misc nft-editions bugs/improvements #13

merged 15 commits into from
Oct 14, 2021

Conversation

nickadamson
Copy link
Member

  • misc fixes

nickadamson and others added 15 commits October 1, 2021 16:45
[fix]: gas efficiency
db88c8b 
old method vs new method
for 4 split recipients: 163361 -> 157551
8SR: 292732	->	286233
iterating through an array is already inefficient enough as is.
[bug] operator is not the NFTaddress, remove event
aff869e 
add to minter.sol
[chore] update rinkeby editions address
dcd9d3d
Merge pull request #12 from ourz-network/breaking-changes
1fa1905 
fix event misunderstanding
clarification in naming and comments
a1aeeda
remove partybid, add execute arbitray call
d4873ea 
partybid isn't really enhance in any form by splits
execute allows splits to work with things like manifold.xyz or any other
minting contracts that are yet to exist on mainnet
[fix] solhint
6a456be
approve owner as minter in createZoraEdition
b2f9dff
fully remove partybid
0b954ee
clarification
6be93b5
[fix] add edition event params + bump interface
43c74a9
[fix] oversight: call proxy not factory
a5c70a0
[feat] option to set salePrice & allow publicMint
c9979d5
[fix] implement mint & withdraw funds from edition
c37a480
add .solcx-lock to gitignore
6d2ac81
@nickadamson nickadamson added this to the Mainnet Release milestone Oct 14, 2021
@nickadamson nickadamson self-assigned this Oct 14, 2021
@nickadamson nickadamson changed the title [feat] implement nft-editions [fix] misc nft-editions bugs/improvements Oct 14, 2021
@nickadamson nickadamson merged commit 211d43d into main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nickadamson nickadamson

Labels
created-by: ourz team feature request Request a feature be added
Projects
None yet
Milestone
Mainnet Release
Development

Successfully merging this pull request may close these issues.
1 participant
@nickadamson