Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Asks Core #158

Merged
merged 4 commits into from
Mar 30, 2022
Merged

feat: Asks Core #158

merged 4 commits into from
Mar 30, 2022

Conversation

kulkarohan
Copy link
Contributor

@kulkarohan kulkarohan commented Mar 25, 2022

New Module Proposal

Description

Minimal, gas-efficient ETH and ERC-20 asks for ERC-721 tokens.

Motivation and Context

AsksCoreEth and AsksCoreErc20 are smaller variants of AsksV1_1, enabling simpler and more gas-efficient NFT listings.

How has this been tested?

Relevant tests have been included via Foundry.

Checklist:

  • The module includes tests written for Foundry
  • The module is documented with NATSPEC
  • The documentation includes UML Diagrams for external and public functions
  • The module is a Hyperstructure

@kulkarohan kulkarohan changed the title feat: Asks Core ETH feat: Asks Core Mar 26, 2022
@kulkarohan kulkarohan merged commit 7d6b81f into main Mar 30, 2022
@kulkarohan kulkarohan deleted the asks branch March 30, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant