Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-correct env map and external emittance flags in optimization #32

Closed
ousnius opened this issue Apr 17, 2022 · 3 comments
Closed

Auto-correct env map and external emittance flags in optimization #32

ousnius opened this issue Apr 17, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@ousnius
Copy link
Owner

ousnius commented Apr 17, 2022 •
edited
Loading

For OptimizeFor and SSE NIF Optimizer, add a new option to find mismatching external emittance flags between BSXFlags and shaders and env map shader type without the env map shader flag.

See https://gitlab.com/G_ka/Cathedral_Assets_Optimizer/-/issues/116
@ousnius ousnius added the enhancement New feature or request label Apr 17, 2022
ousnius added a commit that referenced this issue Jan 2, 2023
@ousnius
Option to correct env map and external emittance flags #32
ca04a14
@ousnius ousnius closed this as completed Jan 2, 2023
@ousnius
Copy link
Owner Author

ousnius commented Jan 2, 2023

@Guekka I implemented the required functions for this.

@Guekka
Copy link
Contributor

Guekka commented Jan 4, 2023

@ousnius Nice! Thank you
Any reason for disabling it by default?

@ousnius
Copy link
Owner Author

ousnius commented Jan 4, 2023

@ousnius Nice! Thank you Any reason for disabling it by default?

The issue description is outdated, the options are true (on) by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ousnius @Guekka