add option for data frame #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2023
Merged
Samahu
changed the base branch from
ros2-compatibility-mode
to
fireflyautomatix-config-data-frame-staging
Samahu
changed the base branch from
fireflyautomatix-config-data-frame-staging
to
ros2
Samahu
changed the base branch from
ros2
to
fireflyautomatix-config-data-frame-staging
Samahu
deleted the branch
ouster-lidar:fireflyautomatix-config-data-frame-staging
|
@Aposhian somehow I closed you PR since I deleted the staging branch that I was using to resolve the conflicts between our repo and yours .. I had to do this because I don't have access to edit the PR.. I wanted to delete my branch and start from the point where our repos were on the same page. so I deleted my branch and by doing that it and since the PR was point the deleted branch it closed the PR. long story short I will accommodate your suggestion into the PR #146 which already references this PR. |
This was referenced Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues & PRs
#33
Summary of Changes
Validation
In progress. If the TFs are setup correctly, both results should result in equivalent visualizations in rviz or foxglove.