Adding a side effecting function called only on success. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marenzo
reviewed
Jan 16, 2017
| * @param consumer the result consumer for the current future result | ||
| * @return a future with same value | ||
| */ | ||
| ComposableFuture<T> peek(Consumer<? super T> consumer); |
There was a problem hiding this comment.
the reason I haven't added such method, is becase #andThen method provides Try object - on which on top you can perform same transformation functions (map, recover, etc).
I don't think there's a meaning in such method, and if so, should be j.u.f.Consumer of T and not Try :)
marenzo
reviewed
Jan 16, 2017
| @@ -55,7 +55,7 @@ | |||
| * Continues a future with a handler that will be called only if the original future resulted with success | |||
| * in case of an error the error is continued forward. | |||
| * | |||
| * @param mapper the continuation handler that returns a future | |||
| * @param mapper the continuation handler that returns a value or throws an exception. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.